Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor terraform CLI tests with mock component #1018

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

Cerebrovinny
Copy link
Collaborator

what

This PR fixes the terraform usage from examples folder during tests in github actions

why

We should focus on testing atmos functionality and not use real terraform weather API's
Screenshot 2025-02-04 at 13 56 28

references

@Cerebrovinny Cerebrovinny marked this pull request as ready for review February 4, 2025 13:57
@Cerebrovinny Cerebrovinny requested review from a team as code owners February 4, 2025 13:57
@mergify mergify bot added the triage Needs triage label Feb 4, 2025
tests/fixtures/README.md Outdated Show resolved Hide resolved
tests/fixtures/atmos.yaml Outdated Show resolved Hide resolved
tests/fixtures/atmos.yaml Outdated Show resolved Hide resolved
tests/fixtures/atmos.yaml Outdated Show resolved Hide resolved
tests/fixtures/atmos.yaml Outdated Show resolved Hide resolved
@Cerebrovinny Cerebrovinny requested a review from osterman February 5, 2025 18:57
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 5, 2025
@mergify mergify bot removed the triage Needs triage label Feb 5, 2025
@mergify mergify bot added the triage Needs triage label Feb 5, 2025
Cerebrovinny and others added 6 commits February 5, 2025 19:51
* sanitize snapshots

* [autofix.ci] apply automated fixes

* check for empty repo root

* normalize slashes

* normalize slashes

* try to fix windows snapshots with windows paths

* handle multiple slashes

* handle multiple slashes

* changed strategy for removing double slashes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <[email protected]>
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 5, 2025
@mergify mergify bot removed the triage Needs triage label Feb 5, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 6, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 7, 2025
@mergify mergify bot removed the triage Needs triage label Feb 7, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 9, 2025
@mergify mergify bot removed the triage Needs triage label Feb 9, 2025
Copy link

mergify bot commented Feb 11, 2025

💥 This pull request now has conflicts. Could you fix it @Cerebrovinny? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Feb 11, 2025
@mergify mergify bot removed the conflict This PR has conflicts label Feb 11, 2025
Copy link

mergify bot commented Feb 11, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cloudposse Needs Cloud Posse assistance triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants