-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --upload
flag to atmos describe affected
command
#631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking really good! I left a few comments and asked for some changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple more small comments/requests for change and then this looks good to merge to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the PR, but still don't agree that we shouldn't warn/error when the API token isn't set (see my comment).
These changes were released in v1.82.0. |
what
--upload
flag toatmos describe affected
commandwhy
If the
--upload=true
command-line flag is passed, Atmos will upload the affected components and stacks to a specified HTTP endpoint.The endpoint can process the affected components and their dependencies in a CI/CD pipeline (e.g. execute
terraform apply
on all the affected components in the stacks and all the dependencies).Atmos will perform an HTTP POST request to the URL
${ATMOS_PRO_BASE_URL}/${ATMOS_PRO_ENDPOINT}
, where the base URL is defined by theATMOS_PRO_BASE_URL
environment variable, and the URL path is defined by theATMOS_PRO_ENDPOINT
environment variable.An Authorization header
Authorization: Bearer $ATMOS_PRO_TOKEN
will be added to the HTTP request (if theATMOS_PRO_TOKEN
environment variable is set) to provide credentials to authenticate with the server.NOTE: If the
--upload=true
command-line flag is passed, the--include-dependencies
and--include-settings
flags are automatically set totrue
, so the affected components will be uploaded with their dependencies and settings (if they are configured in Atmos stack manifests).The payload of the HTTP POST request will be a JSON object with the following schema:
where:
base_sha
- the Git commit SHA of the base branch against which the changes in the current commit are comparedhead_sha
- the SHA of the current Git commitrepo_url
- the URL of the current repositoryrepo_host
- the host of the current repositoryrepo_name
- the name of the current repositoryrepo_owner
- the owner of the current repositorystacks
- a list of affected components and stacks with their dependencies