-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger workflows from github actions bot #890
Conversation
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
Warning Rate limit exceeded@osterman has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 31 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request introduces a new configuration in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/mergify.yml
(1 hunks)
🔇 Additional comments (2)
.github/mergify.yml (2)
22-27
: 🛠️ Refactor suggestion
Add synchronization event check
The rule name suggests it should trigger on PR synchronization, but there's no explicit check for this event. This could cause unnecessary workflow runs.
Add the synchronization check:
conditions:
+ - "check-success~=^Synchronization complete"
- and: *is_a_bot
- and: *is_open
- and: *is_default_branch
Likely invalid or redundant comment.
28-38
: Consider adding error handling and rate limiting
The workflow dispatch configuration could benefit from some additional safeguards:
- Error handling for failed dispatches
- Rate limiting to prevent excessive triggers
Consider adding:
actions:
comment:
message: |
Triggering the workflow dispatch for preview build...
+ # Add a unique identifier for tracking
+ ID: {{ pull_request.number }}-{{ pull_request.head.sha }}
github_actions:
workflow:
dispatch:
- workflow: website-preview-build.yml
ref: "{{ pull_request.head.ref }}"
+ # Add rate limiting
+ max_dispatch_per_hour: 5
- workflow: test.yml
ref: "{{ pull_request.head.ref }}"
+ max_dispatch_per_hour: 5
Let's verify the workflow files exist:
These changes were released in v1.131.0. |
what
why
github-actions[bot]
will not trigger workflows (by design) unless a PAT is usedtests
Summary by CodeRabbit