Add Storage Class Annotation to Jenkins Chart #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Mar 20, 2017
| @@ -10,7 +10,12 @@ metadata: | |||
| release: "{{ .Release.Name }}" | |||
| heritage: "{{ .Release.Service }}" | |||
| annotations: | |||
| {{- if not (empty .Values.Persistence.StorageClass) }} | |||
| volume.beta.kubernetes.io/storage-class: {{ .Values.Persistence.StorageClass | quote }} | |||
| volume.alpha.kubernetes.io/storage-class: {{ .Values.Persistence.StorageClass | quote }} | |||
There was a problem hiding this comment.
I think volume.alpha.kubernetes.io/storage-class has been deprecated - but cannot find where I read that
osterman
reviewed
Mar 20, 2017
| port: {{.Values.Master.ContainerPort}} | ||
| initialDelaySeconds: 60 | ||
| periodSeconds: 1 | ||
| timeoutSeconds: 3 | ||
| successThreshold: 1 | ||
| failureThreshold: 10 | ||
| livenessProbe: | ||
| httpGet: | ||
| path: /login | ||
| tcpSocket: |
There was a problem hiding this comment.
Something suspect here... This has been working, why do we need to change it now? I prefer to stick with http health check. Can we ping a different URL? e.g. Image/CSS/JS asset?
osterman
requested changes
Mar 20, 2017
osterman
changed the title
* master: (24 commits) Revert back exporter-kube-state into kube-prometheus deps (#105) Fix charts CI\CD (#104) Add Support for Email Alerts in Prometheus Alert Manager (#103) Prometheus 2.1 (#80) Added prometheus custom alerts chart (#102) Added prometheus exporter kubelets (#93) Added prometheus exporter kube state (#94) Added prometheus exporter kube scheduler (#95) Added prometheus exporter kube etcd (#96) Added prometheus exporter kube controller manager (#98) Added prometheus exporter kube api (#99) Added prometheus exporter kubernetes (#100) Added prometheus exporter node (#101) Added prometheus exporter kube dns (#97) Added prometheus default selectors for rules and service Monitors (#92) Support Operator 0.7.0 (#91) Bump Grafana Chart Version (#90) Add Kubernetes State Exporter for Prometheus (#85) Add Grafana (#86) Add Prometheus Operator (#81) ...
osterman
approved these changes
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
volume.beta.kubernetes.io/storage-class-why