Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set listener tags #122

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Allow to set listener tags #122

merged 3 commits into from
Sep 14, 2022

Conversation

welderpb
Copy link
Contributor

what

  • Allow add tags to created listeners.

why

  • In some cases we need to tag listeners.

references

@welderpb welderpb requested review from a team as code owners September 14, 2022 10:44
@welderpb welderpb requested review from dotCipher and RothAndrew and removed request for a team September 14, 2022 10:44
nitrocode
nitrocode approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test all

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 2c3040f into cloudposse:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag listeners
3 participants
@welderpb @nitrocode @cloudpossebot