Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacelift-worker-pool README update and AMI limits #573

Closed
wants to merge 2 commits into from

Conversation

johncblandii
Copy link
Contributor

what

  • Limited the AMI to x86_64. This might not be required so can remove this from the PR, if necessary.
  • Updated the README to include other required vars

why

  • The AMI search would retrieve arm64 and fail to deploy

references

@arcaven
Copy link
Contributor

arcaven commented Feb 26, 2023

Please consider a variation of this in #577 because that filter approach may more easily be refactored into setting the architecture as an attribute in variables.tf in the near future, or setting it automatically based on the instance type indicated. Not trying to step on toes, I created the PR before I found this PR

@johncblandii
Copy link
Contributor Author

Fair enough. I'm good with that.

@johncblandii johncblandii deleted the feature/spacelift-worker-pool-tweaks branch February 27, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants