Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The access token is now passed in a http header #83

Merged
merged 1 commit into from
Feb 1, 2024
Merged

The access token is now passed in a http header #83

merged 1 commit into from
Feb 1, 2024

Conversation

boris-dyga-SM
Copy link
Contributor

This is done to avoid exposure as the data.http.id (which contains the URL) in the logs.

Added the MacOS .DS_Store files to .gitignore

what

  • The access token is now passed in a http header
  • Added the MacOS .DS_Store files to .gitignore

why

  • This is done to avoid exposure as the data.http.id (which contains the URL) in the logs.

@boris-dyga-SM boris-dyga-SM requested review from a team as code owners January 23, 2024 12:28
@boris-dyga-SM boris-dyga-SM force-pushed the main branch 2 times, most recently from 22cb725 to ac6a4c7 Compare January 24, 2024 06:40
aknysh
aknysh reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boris-dyga-SM

thanks again for the PR

please run

terraform fmt

on all code

and

make init
make github/init
make readme

@boris-dyga-SM
The access token is now passed in a http header
2ab02c7 
This is done to avoid exposure as the data.http.id (which contains
the URL) in the logs.
@boris-dyga-SM
Copy link
Contributor Author

@aknysh , all done

@aknysh
Copy link
Member

aknysh commented Feb 1, 2024

/terratest

aknysh
aknysh approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @boris-dyga-SM

@aknysh aknysh merged commit ece5d22 into cloudposse:main Feb 1, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boris-dyga-SM @aknysh