Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables #37

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Remove unused variables #37

merged 3 commits into from
Oct 8, 2021

Conversation

bendrucker
Copy link
Contributor

What

Removes unused variables that make it easy for a user to fail to correctly pass API keys to https://github.com/cloudposse/terraform-aws-datadog-lambda-forwarder when switching from v0.13 of this module.

Why

References

@bendrucker bendrucker requested review from a team as code owners September 23, 2021 18:03
@bendrucker bendrucker requested a review from a team as a code owner September 23, 2021 18:04
@aknysh
Copy link
Member

aknysh commented Oct 8, 2021

/test all

aknysh
aknysh approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bendrucker

@aknysh aknysh merged commit b55f18b into cloudposse:master Oct 8, 2021
@bendrucker bendrucker deleted the rm-unused-vars branch October 8, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@florian0410 florian0410 Awaiting requested review from florian0410

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bendrucker @aknysh @cloudpossebot