-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update test framework to use latest best practices and reduce boilerplate #100
Conversation
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
/terratest |
9e6421b
to
2569d13
Compare
/terratest |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks everyone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcalhoun Has a bunch of improvements he told me he would like to see on these test (deferring more to Terratest, using more standard ways of skipping the "existing deployment" test, etc.), so let's give him a few days to make those changes.
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcalhoun Will get to fixing these tests later. This is good enough for now. I added comments about how this is work-in-progress and should not be duplicated.
These changes were released in v0.26.0. |
what
Update this module's test framework. Reduce boilerplate and make reusable functions.
Changelog:
go
to 1.21.test/Makefile
andtest/src/Makefile
from https://github.com/cloudposse/terraform-aws-eks-node-group/tree/e9f908c026d8ca5dc30190a050de68a510ff3983/testenabled=true
from fixtures and add new testTestExamplesCompleteDisabled
for whenenabled=false
Test_ExistingDeployment
for faster test cycle, and modify Makefile accordinglywhy
references