-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add storage_type parameter #79
Conversation
@Gowiem @florian0410 |
Hi! Any estimation when this will be ready? Thanks |
We urgently need this PR to be merged and really would appreciate if progress can be made. Thank you. |
/terratest |
Hey folks, quick update: We're looking into why our CI didn't run and then we'll get this approved and merged. Apologies for the delay and thanks for the pings. Going forward if you do want some functionality like this merge, feel free to ping us in the SweetOps slack via the #pr-reviews channel and someone will be faster to get to you. Side note -- @adubeniuk, since this is being asked for by a few folks I just want to move it along, but I would normally request that you add a validation block to your new |
hi @Gowiem |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @adubeniuk, unfortunately, we need to run some automation to pass our tests. Mind doing the following locally, committing the result, and pushing to your branch?
Thanks! |
hi @Gowiem, updated Readme, thanks |
/terratest |
@adubeniuk thanks for the hard work! This has been released as https://github.com/cloudposse/terraform-aws-documentdb-cluster/releases/tag/0.25.0 👍 |
@Gowiem |
what
Amazon has announced IO-optimized storage type for DocumentDB. Support for it has been added since HashiCorp AWS provider version 5.29.0
why
Keep standard as default but also add ability to create IO-optimized DocumentDB clusters.
references
https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-documentdb-i-o-optimized/
https://registry.terraform.io/providers/hashicorp/aws/5.29.0/docs/resources/docdb_cluster#storage_type