Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Update variable description #99

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[CHORE] Update variable description #99

merged 1 commit into from
Jun 7, 2024
+7 −7

Conversation

RuiSMagalhaes
Copy link
Contributor

@RuiSMagalhaes RuiSMagalhaes commented Jun 7, 2024 •
edited
Loading

what

  • Updates enabled_cloudwatch_logs_exports variable description
  • Updates examples
  • Updates README.md and docs/terraform.md

why

  • Ir order to have the right list of logs available in the variable description

references

@RuiSMagalhaes RuiSMagalhaes requested review from a team as code owners June 7, 2024 15:54
@RuiSMagalhaes RuiSMagalhaes requested review from Gowiem and jamengual June 7, 2024 15:54
@mergify mergify bot added the triage Needs triage label Jun 7, 2024
@RoseSecurity
Copy link

/terratest

RoseSecurity
RoseSecurity approved these changes Jun 7, 2024
View reviewed changes
Copy link

@RoseSecurity RoseSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RuiSMagalhaes Thank you for this contribution! Looks great!

@mergify mergify bot removed the triage Needs triage label Jun 7, 2024
@RoseSecurity RoseSecurity enabled auto-merge (squash) June 7, 2024 21:40
@RoseSecurity RoseSecurity merged commit 41e8647 into cloudposse:main Jun 7, 2024
32 checks passed
@RoseSecurity
Copy link

And thank you for closing out an issue!

@RuiSMagalhaes RuiSMagalhaes deleted the change-var-desc branch June 10, 2024 09:39
@github-actions GitHub Actions
Copy link

These changes were released in v0.26.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoseSecurity RoseSecurity RoseSecurity approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enabled_cloudwatch_logs_exports description is incorrect
2 participants
@RuiSMagalhaes @RoseSecurity