Enable encryption and do not request a specific role #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
reviewed
Mar 16, 2018
| resource "aws_appautoscaling_target" "read_target" { | ||
| max_capacity = "${var.autoscale_max_read_capacity}" | ||
| min_capacity = "${var.autoscale_min_read_capacity}" | ||
| resource_id = "table/${module.default.id}" | ||
| role_arn = "${data.aws_iam_role.autoscale_service.arn}" |
There was a problem hiding this comment.
@osterman
it was like this before.
you changed it to use AWSServiceRoleForApplicationAutoScaling_DynamoDBTable because of
I had to use that to get idempotent apply
or some other issues?
There was a problem hiding this comment.
Ya, exactly. Everytime I ran terraform apply there was a change set.
@darend what happens if you run it twice?
There was a problem hiding this comment.
This was fixed in a newer AWS provider: hashicorp/terraform-provider-aws#3303
osterman
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
AWSServiceRoleForApplicationAutoScaling_DynamoDBTablerole.why
1.11(Requires AWS provider 1.11: Support encryption at rest for DynamoDB tables hashicorp/terraform-provider-aws#3303)