Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terraform-null-label repo name and version #13

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Update terraform-null-label repo name and version #13

merged 2 commits into from
Jul 20, 2018

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jul 20, 2018

what

  • Update terraform-null-label repo name and version

why

  • Very old version is used
  • CI/CD fails
  • Requires terraform fmt

@aknysh aknysh self-assigned this Jul 20, 2018
@aknysh aknysh requested review from osterman and vadim-gleif July 20, 2018 04:08
osterman
osterman reviewed Jul 20, 2018
View reviewed changes
README.yaml Outdated
@@ -11,7 +11,7 @@ name: terraform-aws-ec2-ami-backup
#logo: docs/logo.png

# License of this project
license: "MIT"
license: "APACHE2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project is forked, so we should probably maintain the upstream license.

osterman
osterman requested changes Jul 20, 2018
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert license change.

@aknysh aknysh requested a review from osterman July 20, 2018 19:16
@aknysh aknysh merged commit 599863a into master Jul 20, 2018
@aknysh aknysh deleted the update-module-versions branch July 20, 2018 19:23
@osterman osterman mentioned this pull request Jul 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@vadim-gleif vadim-gleif Awaiting requested review from vadim-gleif

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknysh @osterman