Created TF module to perform AMI backups using Lamda Functions #2
Conversation
const-bon
force-pushed
the
lambda_ami_review
branch
from
b48e31b to
bec3b82
Compare
main.tf
Outdated
|
|
||
| statement { | ||
| actions = [ | ||
| "ec2:*", |
There was a problem hiding this comment.
Added
"ec2:DescribeInstances",
"ec2:CreateImage",
"ec2:CreateTags"
main.tf
Outdated
| resource "aws_lambda_function" "ami_backup" { | ||
| filename = "${path.module}/lambda_ami_backups.zip" | ||
| function_name = "${module.label_backup.id}" | ||
| description = "Automatically backs up instances tagged with backup: true" |
There was a problem hiding this comment.
Replaced with Automatically backup instances tagged with 'backup: true'
main.tf
Outdated
| resource "aws_lambda_function" "ami_cleanup" { | ||
| filename = "${path.module}/lambda_ami_cleanups.zip" | ||
| function_name = "${module.label_cleanup.id}" | ||
| description = "Cleans up old AMI backups" |
There was a problem hiding this comment.
Replaced with Cleanup old AMI backups
main.tf
Outdated
|
|
||
| resource "aws_cloudwatch_event_rule" "ami_backup" { | ||
| name = "${module.label_backup.id}" | ||
| description = "Schedule for ami snapshot backups" |
There was a problem hiding this comment.
Replaced with Schedule for AMI snapshot backups
main.tf
Outdated
|
|
||
| resource "aws_cloudwatch_event_rule" "ami_cleanup" { | ||
| name = "${module.label_cleanup.id}" | ||
| description = "Schedule for ami snapshot cleanup" |
There was a problem hiding this comment.
Replaced with Schedule for AMI snapshot cleanup
main.tf
Outdated
|
|
||
| resource "aws_cloudwatch_event_target" "ami_backup" { | ||
| rule = "${aws_cloudwatch_event_rule.ami_backup.name}" | ||
| target_id = "schedule_ami_backups" |
There was a problem hiding this comment.
I think this needs to be namespaced
There was a problem hiding this comment.
Replaced with target_id = "${module.label_backup.id}"
main.tf
Outdated
|
|
||
| resource "aws_cloudwatch_event_target" "ami_cleanup" { | ||
| rule = "${aws_cloudwatch_event_rule.ami_cleanup.name}" | ||
| target_id = "schedule_ami_cleanups" |
There was a problem hiding this comment.
Does this need to be namespaced?
There was a problem hiding this comment.
Replaced with target_id = "${module.label_cleanup.id}"
|
Applied all required fixes. |
main.tf
Outdated
| resource "aws_lambda_function" "ami_backup" { | ||
| filename = "${path.module}/ami_backup.zip" | ||
| function_name = "${module.label_backup.id}" | ||
| description = "Automatically backup instances tagged with 'backup: true'" |
What
Why
References