Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make required outputs sensitive #113

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

syphernl
Copy link
Contributor

@syphernl syphernl commented Feb 8, 2021

what

  • Marks the outputs sensitive to be compatible with TF 0.14

why

  • Otherwise TF 0.14 would give an Error: Output refers to sensitive values when using this module

references

@syphernl syphernl requested review from a team as code owners February 8, 2021 09:49
@syphernl syphernl changed the title fix: make codebuild output sensitive fix: make required outputs sensitive Feb 9, 2021
@Gowiem
Copy link
Member

Gowiem commented Feb 9, 2021

/test all

@Gowiem Gowiem merged commit e9df99f into cloudposse:master Feb 9, 2021
@syphernl syphernl deleted the fix/tf14_add_sensitive branch February 9, 2021 16:24
kevcube added a commit to kevcube/terraform-aws-ecs-atlantis that referenced this pull request Mar 10, 2021
aknysh pushed a commit to cloudposse-archives/terraform-aws-ecs-atlantis that referenced this pull request Mar 10, 2021
* Make vars sensitive

cloudposse/terraform-aws-ecs-web-app#113 <-- That PR broke this module.

* Auto Format

* empty commit to trigger actions

Co-authored-by: cloudpossebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants