Requested features, general updates #110
Conversation
Nuru
added
bugfix
|
/test all |
| @@ -162,7 +162,7 @@ module "eks_node_group" { | |||
|
|
|||
| # Ensure ordering of resource creation to eliminate the race conditions when applying the Kubernetes Auth ConfigMap. | |||
| # Do not create Node Group before the EKS cluster is created and the `aws-auth` Kubernetes ConfigMap is applied. | |||
| depends_on = [module.eks_cluster.kubernetes_config_map_id] | |||
| depends_on = [module.eks_cluster, module.eks_cluster.kubernetes_config_map_id] | |||
There was a problem hiding this comment.
I would think depends_on = [module.eks_cluster.kubernetes_config_map_id] implies depends_on = [module.eks_cluster], no?
There was a problem hiding this comment.
I would expect that you are right, but I did not want to spend the time to test it, and I ran into problems with the previous version.
| from_port = 0 | ||
| to_port = 65535 | ||
| protocol = "tcp" | ||
| description = "Allow SSH egress" |
There was a problem hiding this comment.
we do we call it "SSH egress" if all the ports are open?
There was a problem hiding this comment.
It is called "SSH egress" because the ports are only open to destinations from which SSH ingress is allowed.
There was a problem hiding this comment.
I know this is an old PR, but I'm looking back on this and curious why the ssh egress rule was needed given SecurityGroups are stateful
what && why
Combine feature requests, bug fixes, and general updates into a single PR to reduce number of releases and also expedite requested changes to PRs.
ami_type="CUSTOM", resolves Allow value CUSTOM for input ami_type for use with Launch Templates #96, thank you @ingledlssh_access_security_group_idswhether or not an SSH key is provided, resolves Support EC2 Instance Connect Send SSH Key #108, thank you @bcbrockwayenabled=false, update workflows: general maintenance and conformity