Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow traffic inside security group #145

Merged
merged 6 commits into from
Jul 5, 2022
Merged

Conversation

kevcube
Copy link
Contributor

@kevcube kevcube commented Jun 30, 2022

boolean flag to enable intra-security group communication.

why

  • we create our app infrastructure beginning with the database, then we use the output security group ID that gets created by Postgres as an input in our application, to give it database access
  • previously what we've done is create the database, create the app, and add the app security group to the database's inputs, but this makes circular dependencies because our app depends on other outputs of the database

@kevcube kevcube requested review from a team as code owners June 30, 2022 20:34
@kevcube kevcube requested review from Gowiem and Benbentwo June 30, 2022 20:34
@Gowiem
Copy link
Member

Gowiem commented Jun 30, 2022

/test all

@Gowiem
Copy link
Member

Gowiem commented Jun 30, 2022

@kevcube mind sharing where this is necessary in your PR description? That "Why" is helpful to understanding if this should be merged.

@kevcube
Copy link
Contributor Author

kevcube commented Jun 30, 2022

@Gowiem added! I created my PR from GitHub.dev and it doesn't add any template 😵‍💫

@Gowiem
Copy link
Member

Gowiem commented Jul 5, 2022

/test all

Gowiem
Gowiem previously requested changes Jul 5, 2022
Co-authored-by: Matt Gowie  <[email protected]>
@mergify mergify bot dismissed Gowiem’s stale review July 5, 2022 19:42

This Pull Request has been updated, so we're dismissing all reviews.

@kevcube
Copy link
Contributor Author

kevcube commented Jul 5, 2022

@Gowiem fixed

@Gowiem
Copy link
Member

Gowiem commented Jul 5, 2022

/test all

@Gowiem Gowiem merged commit e83b697 into cloudposse:master Jul 5, 2022
@Gowiem
Copy link
Member

Gowiem commented Jul 5, 2022

@kevcube Thanks for the contribution! Released as https://github.com/cloudposse/terraform-aws-rds-cluster/releases/tag/1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants