Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support reserved instances #233

Merged
merged 5 commits into from
Sep 12, 2024
Merged

feat: support reserved instances #233

merged 5 commits into from
Sep 12, 2024

Conversation

kevcube
Copy link
Contributor

@kevcube kevcube commented Sep 12, 2024 •
edited
Loading

questions

  • do we want to allow customization of the count/size of reserved instances?

@kevcube kevcube requested review from a team as code owners September 12, 2024 14:16
@mergify mergify bot added the triage Needs triage label Sep 12, 2024
aknysh
aknysh previously requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kevcube ,

please run terraform fmt

https://github.com/cloudposse/terraform-aws-rds-cluster/actions/runs/10832707614/job/30057726279?pr=233

@aknysh
Copy link
Member

aknysh commented Sep 12, 2024

/terratest

@kevcube
Copy link
Contributor Author

kevcube commented Sep 12, 2024

/terratest

@kevcube kevcube requested a review from aknysh September 12, 2024 15:45
@kevcube
Copy link
Contributor Author

kevcube commented Sep 12, 2024

/terratest

@kevcube kevcube enabled auto-merge (squash) September 12, 2024 16:32
aknysh
aknysh approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kevcube

@kevcube kevcube merged commit 9d1ecd6 into main Sep 12, 2024
22 checks passed
@kevcube kevcube deleted the reserved_instances branch September 12, 2024 17:43
@mergify mergify bot removed the triage Needs triage label Sep 12, 2024
@github-actions GitHub Actions
Copy link

These changes were released in v1.11.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevcube @aknysh