fix: reserved instances restrictions #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gowiem
added
patch
|
/terratest |
Gowiem
approved these changes
Dec 11, 2024
|
I can't see the particular check that says it's "cancelled", and I don't have permissions to merge either. Hoping a maintainer can jump in for an additional review + merge! (@gberenice maybe?) |
|
These changes were released in v1.15.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This conditional check on whether or not to enable reserved instances is too restrictive.
contains(["mysql", "postgresql"], local.reserved_instance_engine)is saying that only allow it if it is MySQL or PostgreSQL.I think
containswas originally meant to be like in the literal sense of "contains". Since in my case, I'm usingaurora-postgresql, and it fails this check, yet it is one of the options for reserved instances.why
endswithmight be better, but it is TOO restrictive, seeing that there's so many options.Additionally, Terraform will fail if user specifies the wrong engine type. There's no need for this check.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/rds_reserved_instance_offering