Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to exclude an3 controls not supported #24

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

mcalhoun
Copy link
Member

what

  • Update the control disablement module to exclude controls not supported in ap-northeast-3

why

  • Certain controls are not supported in ap-northeast-3, so we should not try to disable them when that is the current region

@mcalhoun mcalhoun requested review from a team as code owners July 16, 2021 14:09
@mcalhoun mcalhoun requested review from jhosteny and joe-niland July 16, 2021 14:09
@mcalhoun mcalhoun added the patch A minor, backward compatible change label Jul 16, 2021
@mcalhoun
Copy link
Member Author

/test all

"${local.control_prefix}/cis-aws-foundations-benchmark/v/1.2.0/1.12",
"${local.control_prefix}/cis-aws-foundations-benchmark/v/1.2.0/1.20"
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcalhoun
maybe we can create a map of regions to lists of not supported controls?

not_supported_region_controls = {
   "ap-northeast-3" = [
     "${local.control_prefix}/aws-foundational-security-best-practices/v/1.0.0/IAM.4",
      "${local.control_prefix}/cis-aws-foundations-benchmark/v/1.2.0/1.12",
      "${local.control_prefix}/cis-aws-foundations-benchmark/v/1.2.0/1.20"
   ]
}

otherwise LGTM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, it's just a broken region...everything else is supported everywhere.

@mcalhoun mcalhoun merged commit d88b37b into master Jul 16, 2021
@mcalhoun mcalhoun deleted the bug/fix-an3-control-disablements branch July 16, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants