Add enabled toggle #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
osterman
approved these changes
Aug 3, 2021
max-lobur
approved these changes
Aug 3, 2021
aknysh
reviewed
Aug 3, 2021
| @@ -15,9 +19,9 @@ resource "aws_sns_topic" "this" { | |||
| } | |||
|
|
|||
| resource "aws_sns_topic_subscription" "this" { | |||
| for_each = var.subscribers | |||
| for_each = local.enabled ? var.subscribers : {} | |||
There was a problem hiding this comment.
@nitrocode did you test it with enabled=false?
usually in this case terraform complains that both sides of the ? operator must have the same types (not only it must be a map, but all items must be the same with the same types)
There was a problem hiding this comment.
@aknysh var.subscribers is a map so both types are the same.
$ git clone [email protected]:cloudposse/terraform-aws-sns-topic.git
$ cd terraform-aws-sns-topic
$ terraform init
$ echo '\nenabled = false\n' >> fixtures.us-east-2.tfvars
$ terraform plan -var-file=fixtures.us-east-2.tfvars
Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.
module.sns.data.aws_caller_identity.current: Refreshing state...
------------------------------------------------------------------------
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
Terraform will perform the following actions:
Plan: 0 to add, 0 to change, 0 to destroy.There was a problem hiding this comment.
var.subscribers is a map so both types are the same
yes, but in similar cases Terraform complains that not only the container types must be the same (maps), but they must have the the items and the same item types
There was a problem hiding this comment.
What would you propose to use here instead ?
aknysh
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references
N/A