Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: support tenant label by updating version of null-label module for aws_dynamodb_table #99

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Fix: support tenant label by updating version of null-label module for aws_dynamodb_table #99

merged 2 commits into from
Aug 23, 2021

Conversation

korenyoni
Copy link
Member

what

  • Bump null-label module for aws_dynamodb_table resource to 0.25.0 in order to support tenant label.

why

  • context.tf in this module supports tenant because its instantiation of null-label has been auto-updated to 0.25.0, but the instantiation of null-label module for the aws_dynamodb_table resource has not been updated.

references

@korenyoni korenyoni requested review from a team as code owners August 23, 2021 22:02
@korenyoni korenyoni requested a review from a team as a code owner August 23, 2021 22:03
@korenyoni
Copy link
Member Author

/test all

@nitrocode nitrocode added the patch A minor, backward compatible change label Aug 23, 2021
@korenyoni korenyoni merged commit d084523 into master Aug 23, 2021
@korenyoni korenyoni deleted the fix/update-null-label-support-tenant branch August 23, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korenyoni @nitrocode @cloudpossebot