Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make region optional #30

Merged
merged 4 commits into from
Aug 16, 2022
Merged

make region optional #30

merged 4 commits into from
Aug 16, 2022

Conversation

mcalhoun
Copy link
Member

@mcalhoun mcalhoun commented Aug 1, 2022

what

  • Update the provider to make the region parameter option

why

  • To keep this provider in sync with the upstream provider functionality

references

Closes #28

@mcalhoun mcalhoun requested review from a team as code owners August 1, 2022 17:27
@renilthomas renilthomas mentioned this pull request Aug 2, 2022
Closed
@mcalhoun mcalhoun merged commit 49ba7f1 into main Aug 16, 2022
@mcalhoun mcalhoun deleted the feature/make-region-optional branch August 16, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make region optional like in the aws provider
2 participants
@mcalhoun @aknysh