Tune aws-nuke: skip S3Objects, include RedShift

[Nuru]

what

• Tune aws-nuke: skip S3Objects, delete RedShift resources, ECS Task Definitions, and OIDC connectors
• Update Geodesic to current and install Terraform 0.15 and 1.x
• Disable nightly Docker builds

why

• Action was timing out after 6 hours, probably because of the overhead of deleting S3 objects one at a time. Not necessary to delete S3 Objects because we will delete entire S3 Buckets which will cause S3 Objects to be deleted as well.
• We now have a tests that provision RedShift clusters and OIDC connectors, but we were not deleting them.
• Support current Terraform version as well as legacy version.
• Image is stable, does not change with nightly builds, and testing now uses curl to pull latest configuration anyway.

[osterman]

Why disable?

[Nuru]

I don't know why we want to build this nightly. It is pinned to a Geodesic version and we do not update Geodesic that often. It just seems a waste of resources to build it nightly.

[osterman]

Aws does not allow deletion of bucket with objects.

I don't believe the hypothesis on too many objects

[osterman]

I rather exit 0 than run manually. Our testing infra orphans way too much to make this manuAl, and even if it fails deleting some stuff is better than not at all.

[Nuru]

Aws does not allow deletion of bucket with objects.

I don't believe the hypothesis on too many objects

The only evidence I have for the hypothesis is

• There were over 7,300 S3 Objects to delete
• There is an open issue complaining about nuke being slow to delete S3 objects
• I did not try to have nuke delete the S3 Objects. Instead I configured nuke to ignore them.
• The resulting nuke run finished in under 20 minutes