Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added error check to return error if view creation query failed. #154

Merged
merged 1 commit into from
Jul 27, 2021
Merged

added error check to return error if view creation query failed. #154

merged 1 commit into from
Jul 27, 2021

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Jul 22, 2021

No description provided.

@amanenk amanenk requested review from michelvocks and roneli July 22, 2021 11:48
roneli
roneli approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, would add a test for this if possible.

michelvocks
michelvocks reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this really fixes the issue because we actually don't return the error during view creation: https://github.com/cloudquery/cloudquery/blob/main/pkg/policy/execute.go#L101

@roneli roneli merged commit ac74e3a into cloudquery:main Jul 27, 2021
@cq-bot cq-bot mentioned this pull request Aug 9, 2022
Merged
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
@zagronitay
feat: Classify error 420 "Too many requests" (#154)
d1d6c89
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
@cq-bot
chore(main): Release v0.5.17 (#169)
b7ca46f 
🤖 I have created a release *beep* *boop*
---


## [0.5.17](cloudquery/cq-provider-digitalocean@v0.5.16...v0.5.17) (2022-06-27)


### Features

* Classify error 420 "Too many requests" ([#154](cloudquery/cq-provider-digitalocean#154)) ([780cd66](cloudquery/cq-provider-digitalocean@780cd66))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
@cq-bot
chore: Synced file(s) with cloudquery/.github (#154)
5c8f876 
Synced local file(s) with [cloudquery/.github](https://github.com/cloudquery/.github).





---

This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#2604403893](https://github.com/cloudquery/.github/actions/runs/2604403893)
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
@cq-bot
fix(deps): Update module github.com/cloudquery/cq-provider-sdk to v0.…
96d539c 
…14.6 (#154)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/cloudquery/cq-provider-sdk](https://togithub.com/cloudquery/cq-provider-sdk) | require | patch | `v0.14.5` -> `v0.14.6` |

---

### Release Notes

<details>
<summary>cloudquery/cq-provider-sdk</summary>

### [`v0.14.6`](https://togithub.com/cloudquery/cq-provider-sdk/releases/tag/v0.14.6)

[Compare Source](https://togithub.com/cloudquery/cq-provider-sdk/compare/v0.14.5...v0.14.6)

##### Features

-   Add new Resolver PathTableResolver ([#&#8203;440](https://togithub.com/cloudquery/cq-provider-sdk/issues/440)) ([90e9c01](https://togithub.com/cloudquery/cq-provider-sdk/commit/90e9c01c6518082b7bb4f61263c716fab86297cf))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzEuMyIsInVwZGF0ZWRJblZlciI6IjMyLjEzMS4zIn0=-->
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
@cq-bot
chore(main): Release v0.5.2 (#155)
a7af5d8 
🤖 I have created a release *beep* *boop*
---


## [0.5.2](cloudquery/cq-provider-terraform@v0.5.1...v0.5.2) (2022-08-07)


### Bug Fixes

* **deps:** Update module github.com/aws/aws-sdk-go to v1.44.66 ([#156](cloudquery/cq-provider-terraform#156)) ([3d54470](cloudquery/cq-provider-terraform@3d54470))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.14.6 ([#154](cloudquery/cq-provider-terraform#154)) ([48cb44f](cloudquery/cq-provider-terraform@48cb44f))
* **deps:** Update module github.com/hashicorp/go-hclog to v1.2.2 ([#157](cloudquery/cq-provider-terraform#157)) ([3a1cc8a](cloudquery/cq-provider-terraform@3a1cc8a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelvocks michelvocks michelvocks left review comments

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanenk @michelvocks @roneli