Gcs poc multi #52
Open
Gcs poc multi #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivv
reviewed
Apr 12, 2024
| Path tempPath = new Path(outputPath, FileOutputCommitter.PENDING_DIR_NAME); | ||
| FileSystem fs = tempPath.getFileSystem(context.getConfiguration()); | ||
| String taskId = context.getTaskAttemptID().getTaskID().toString(); | ||
| Path taskPartitionFile = new Path(tempPath, taskId + "_partitions.txt"); |
There was a problem hiding this comment.
If it's a task retry we should overwrite it
| if (!fs.exists(taskPartitionFile)) { | ||
| fs.createNewFile(taskPartitionFile); | ||
| } | ||
| DataOutputStream out = fs.append(taskPartitionFile); |
There was a problem hiding this comment.
Use try with resources to ensure stream is always closed
| DataInputStream in = new DataInputStream(new BufferedInputStream(dis)); | ||
| BufferedReader br = new BufferedReader(new java.io.InputStreamReader(in)); | ||
| String line; | ||
| while ((line = br.readLine()) != null) { |
There was a problem hiding this comment.
It can have multiple lines if that split has records for multiple table names. E.g. We have country as tableName, and split has records for both US and India, it will write path upto country/suffix into this file.
There was a problem hiding this comment.
one task can be responsible for processing multiple partitions, hence there can be multiple lines.
There was a problem hiding this comment.
Got you. Well, in this case we need to ensure file is removed on the beginning of attempt (in case of any attempt retries)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
We create a _temp dir on the root path and store all the paths,
At the final driver commit we take the set on all the paths and do one commit on each path !