Race condition during startup fix #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemyslaw-dobrowolski-cl
suggested changes
Jul 20, 2017
andriikonstantinov
force-pushed
the
race_condition_fix
branch
from
082ac77 to
ff11e56
Compare
p-kozlowski
suggested changes
Jul 21, 2017
| func transactionCommitInformer() chan int { | ||
| mutex.Lock() |
There was a problem hiding this comment.
prefer sync.Once (cf. https://github.com/cloudwan/gohan/pull/503/files)
There was a problem hiding this comment.
@p-kozlowski Done
andriikonstantinov
force-pushed
the
race_condition_fix
branch
from
ff11e56 to
70c2f20
Compare
|
@przemyslaw-dobrowolski-cl please review again |
przemyslaw-dobrowolski-cl
suggested changes
Jul 28, 2017
| var transactionCommited chan int | ||
| var ( | ||
| transactionCommited chan int | ||
| wasCommited sync.Once |
There was a problem hiding this comment.
What was commited? this name is not self-explaining. Please rename this to something more meaningful, like transactionCommitedOnce or similar
|
@andriikonstantinov Can you provide a proof for this race condition? eg. stack trace? |
andriikonstantinov
force-pushed
the
race_condition_fix
branch
from
70c2f20 to
4e06303
Compare
|
@andriikonstantinov Could you cite any stack trace for this face condition? |
|
@andriikonstantinov please rebase |
|
@przemyslaw-dobrowolski-cl this issue hasn't been observed, it was found by code analysis: #358 |
p-kozlowski
approved these changes
Aug 2, 2017
przemyslaw-dobrowolski-cl
approved these changes
Aug 3, 2017
nati
approved these changes
Aug 3, 2017
andriikonstantinov
force-pushed
the
race_condition_fix
branch
2 times, most recently
from
ca15f9a to
0acb6d0
Compare
|
please rebase |
andriikonstantinov
force-pushed
the
race_condition_fix
branch
from
c2d923a to
ad9bf0a
Compare
marcin-ptaszynski
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#358