panic if FastStr wrapped by Arc

cloudwego · Dec 14, 2022 · 2f8d52b · 2f8d52b
1 parent 06d3a7e
commit 2f8d52b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/pilota-build/src/resolve.rs b/pilota-build/src/resolve.rs
@@ -327,6 +327,8 @@ impl Resolver {
             impl Folder for ArcFolder<'_> {
                 fn fold_ty(&mut self, ty: &Ty) -> Ty {
                     let kind = match &ty.kind {
+                        TyKind::FastStr => panic!("faststr can not be wrapped by Arc"),
+                        TyKind::Bool => panic!("bool can not be wrapped by Arc"),
                         TyKind::Vec(inner) => TyKind::Vec(Arc::new(self.fold_ty(inner.as_ref()))),
                         TyKind::Set(inner) => TyKind::Set(Arc::new(self.fold_ty(inner.as_ref()))),
                         TyKind::Map(k, v) => {

diff --git a/pilota-build/test_data/thrift/wrapper_arc.rs b/pilota-build/test_data/thrift/wrapper_arc.rs
@@ -3,7 +3,7 @@ pub mod wrapper_arc {
     pub mod wrapper_arc {
         #[derive(Debug, Default, Clone, PartialEq)]
         pub struct Test {
-            pub id: ::std::sync::Arc<::pilota::FastStr>,
+            pub id: ::pilota::FastStr,
             pub name2: ::std::vec::Vec<::std::vec::Vec<::std::sync::Arc<i32>>>,
             pub name3: ::std::collections::HashMap<i32, ::std::vec::Vec<::std::sync::Arc<i32>>>,
         }
@@ -86,7 +86,7 @@ pub mod wrapper_arc {
                     let field_id = field_ident.id;
                     match field_id {
                         Some(1i16) if field_ident.field_type == ::pilota::thrift::TType::Binary => {
-                            id = Some(Arc::new(protocol.read_faststr()?));
+                            id = Some(protocol.read_faststr()?);
                         }
                         Some(2i16) if field_ident.field_type == ::pilota::thrift::TType::List => {
                             name2 = Some({
@@ -188,7 +188,7 @@ pub mod wrapper_arc {
                     let field_id = field_ident.id;
                     match field_id {
                         Some(1i16) if field_ident.field_type == ::pilota::thrift::TType::Binary => {
-                            id = Some(Arc::new(protocol.read_faststr().await?));
+                            id = Some(protocol.read_faststr().await?);
                         }
                         Some(2i16) if field_ident.field_type == ::pilota::thrift::TType::List => {
                             name2 = Some({

diff --git a/pilota-build/test_data/thrift/wrapper_arc.thrift b/pilota-build/test_data/thrift/wrapper_arc.thrift
@@ -1,5 +1,5 @@
 struct TEST {
-    1: required string ID(pilota.rust_wrapper_arc="true"),
+    1: required string ID,
     2: required list<list<i32>> Name2(pilota.rust_wrapper_arc="true"),
     3: required map<i32, list<i32>> Name3(pilota.rust_wrapper_arc="true"),
 }