Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic codec support for binary le && binary unsafe #163

Merged
merged 1 commit into from
May 24, 2023

Conversation

PureWhiteWu
Copy link
Member

@PureWhiteWu PureWhiteWu commented May 22, 2023

No description provided.

@PureWhiteWu PureWhiteWu requested review from a team as code owners May 22, 2023 17:20
@PureWhiteWu PureWhiteWu self-assigned this May 22, 2023
@PureWhiteWu PureWhiteWu added A-pilota This issue concerns the main `pilota` crate. C-enhancement This is a PR that adds a new feature or fixes a bug. labels May 22, 2023
@PureWhiteWu PureWhiteWu force-pushed the feat/support_binary_le branch 4 times, most recently from e134687 to 7009bbf Compare May 23, 2023 10:58
@PureWhiteWu PureWhiteWu changed the title feat: add basic codec support for binary le feat: add basic codec support for binary le && binary unsafe May 23, 2023
@PureWhiteWu PureWhiteWu force-pushed the feat/support_binary_le branch 2 times, most recently from 1057e03 to 6ade2c7 Compare May 23, 2023 13:07
@PureWhiteWu PureWhiteWu force-pushed the feat/support_binary_le branch from 6ade2c7 to 75ddae6 Compare May 23, 2023 15:03
@PureWhiteWu PureWhiteWu force-pushed the feat/support_binary_le branch from 75ddae6 to bc99b7b Compare May 23, 2023 15:07
@PureWhiteWu PureWhiteWu added the A-pilota-build This issue concerns the `pilota-build` crate. label May 23, 2023
@ethe
Copy link

ethe commented May 23, 2023

Actually transmute-free little-endian ordered message is related to target, I think only support it on x86 should be better.

@PureWhiteWu PureWhiteWu merged commit 7b2b5f9 into cloudwego:main May 24, 2023
@PureWhiteWu PureWhiteWu deleted the feat/support_binary_le branch May 24, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pilota This issue concerns the main `pilota` crate. A-pilota-build This issue concerns the `pilota-build` crate. C-enhancement This is a PR that adds a new feature or fixes a bug.
Development

Successfully merging this pull request may close these issues.

3 participants