Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate i8 for thrift byte #216

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: generate i8 for thrift byte #216

merged 1 commit into from
Dec 4, 2023

Conversation

Millione
Copy link
Member

@Millione Millione commented Dec 4, 2023 •
edited
Loading

https://thrift.apache.org/docs/types

Notice: maybe a break change for those who already used byte in the idl.

@Millione Millione requested review from a team as code owners December 4, 2023 06:28
@Millione Millione merged commit af4c38f into cloudwego:main Dec 4, 2023
8 checks passed
@Millione Millione deleted the byte/i8 branch April 10, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukiiiteru yukiiiteru yukiiiteru approved these changes

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Millione @PureWhiteWu @yukiiiteru