fix(pilota)/use advance method to align the inner buffer index with the protocol index when feasible #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The inner buffer index might not align with the index of protocol for better performance of vector encoding or decoding. Thus, when we use the
buf
orbuf_mut
interface which return the inner buffer, we might encounter the issue of reading or writing at wrong position of the buffer.Solution
As there are some low frequency option, such as
read_message_begin
, which are not pursuing performance, we can use theadvance
andadvance_mut
method to align the inner buffer index with the index of protocol implement. Then, we can get the right payload afterread_message_begin
.As a reminder, this PR cannot completely resolve the inconsistency problem of these two indexes, so be careful of using the
buf
andbuf_mut
in the middle of processing the thrift message.