Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0.0-beta3 #1151

Merged
merged 22 commits into from
Nov 15, 2024
Merged

v2.0.0-beta3 #1151

merged 22 commits into from
Nov 15, 2024

Conversation

longshuicy
Copy link
Member

[v2.0.0-beta.3] - 2024-07-29

Added

  • License management
  • Release dataset with versions
  • Enable and disable user account through Keycloak
  • Jupyterhub integration
  • Interface for creating and editing matching criteria for triggering extractors
  • Interface for editing metadata definitions
  • My dataset tab listing all the datasets created by the user
  • Drag and drop upload multiple files
  • Footer with links to documentation, source code, and contact information
  • Documentation through MKDocs

Changed

  • Allow public datasets and files to be searchable
  • List all the extractors with the ability to enable/disable the extractors
  • Filter listeners based on their support for file or dataset
  • Helm chart updated to support custom existing secret

Fixed

  • Clowder registration link on the top bar
  • Case-insensitive search
  • Download count immediately increments after download

@lmarini lmarini requested a review from a team July 25, 2024 14:04
@longshuicy
1147 clowder 2 helm chart clean up (#1148)
4d136e8 
* turn off unecessary ingress for minio and rabbitmq

* remove default tls host

* slight update the secret read

* use the wrong secretname

* add more gitignore

* take out default extractors in the default values

* allow backend env to be overwritten by value files with default

* add quote to number and boolean

* allow environment variable setting in heartbeat and message extractors

* extractor doesn't need to be commented out; add message and heartbeat

* use fullname for matching labels

* typo

* allow use existing secret and secret keys

* duplicate rabbitmq pass
@longshuicy
turn off default extractors
91ad4e7
@longshuicy
Copy link
Member Author

Todos:
Helm chart - compute some of the env with _helper.tpl

@longshuicy longshuicy marked this pull request as ready for review August 1, 2024 14:03
tcnichol
tcnichol approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this one out and will mark approved so we can release.

longshuicy and others added 7 commits August 13, 2024 11:58
@longshuicy
Merge branch 'main' into release/v2.0-beta-3
dfcdbde
@longshuicy
Remove helm chart env (#1165)
0a64e47 
* revert env use releaseName to calculate

* fix bug

* fix api host
@longshuicy
set workers based on recommended number of cores (#1170)
8c9eb8a 
* set workers based on recommended number of cores

* turn recreate views to false

* add notes to recreate views flag
@longshuicy
1168 add contents to docs (#1188)
90d65ed 
* add dev handbook

* add dev setup

* mkdocs
@longshuicy
Merge branch 'main' into release/v2.0-beta-3
c6e1267
@tcnichol
error message when sharing dataset with user (#1140)
a28c5fb 
* message works for share dataset with user
strange bug - sharing with group shows 2 entries?

* removing old method
@lmarini
Merge branch 'main' into release/v2.0-beta-3
1712540
@lmarini
Copy link
Member

lmarini commented Oct 1, 2024

  • public datasets give access denied when logged in (work when logged out)
  • analysis tabs show all extraction events, title is not consistent, time stamp is null

lmarini and others added 11 commits November 5, 2024 09:20
@lmarini
Fix/beta 3 extractions list (#1199)
f8588a7 
* Pass file and dataset id from ExtractionHistoryTab into ExtractionJobs to fix rendering of extraction events bugs.

* Fixed message if visualization fails to load.

* Cleaned up ExtractionHistoryTab.tsx and ExtractionJobs.tsx.

* Simplified table row definition in ExtractionJobs.tsx.

* Removed mapping useEffect in ExtractionJobs.tsx.

* Set memory limits for elasticsearch in dev mode to see if it
avoids random startup failures on macs.

* Fixed PydanticObjectId import.

* Fixed duration printing in extraction log.

* Fixed label.

* Fixed refresh button on listing of extraction events.

* Fixed extraction count on listing of extraction events.
@lmarini
Make sure only dataset extractors are shown on the analysis tab for a…
b049af7 
… dataset. (#1200)
@lmarini
When adding metadata, sometimes two instances of it would show up aft…
4ea5404 
…er adding, but (#1201)

only one was on the server (refreshing showed one). Combining the useEffect statements
seems to have fixed that.
At some point we should remove the complex if logic included with the jsx. We might want
to have separate components for dataset and files and a common one for the actual entries.
@longshuicy @ddey2
Rabbitmq host update to release name (#1203)
9a41c8a 
* rabbitmq host will use the releaseName pattern

* update secret name

* added cc username and reading credentials from littlbeats.secret.yaml

---------

Co-authored-by: Dipannita Dey <[email protected]>
@GalMunGral
Fix refresh token issue when using password flow (#1205)
15c47d2 
* deprecate `/login` endpoint and add refresh token saving in `/auth/login`

* fix code formatting

* update API docs

* refactor `TokenDB` logic
@lmarini
Fix edit file metadata bug by making sure (#1207)
700aeb1 
* Fix edit file metadata bug by making sure
that the backend properly sets context when
a metatdata definition is provided.

* Fixed pytest. Posting a string and checking
the result as a string and not a number.
@lmarini
Fix/authenticated datasets access (#1210)
76f5353 
* Show status of dataset on tile.

* Fixed bug where logged in user could not see
authenticated dataset.
Added chip to dataset tile showing access status.

* Fixed bug where logged in user could not see
public dataset.

* Default status to blank when dataset is authenticated.
@GalMunGral
Add endpoint for updating user info (#1206)
96a61d1 
* add user update endpoint

* rename endpoint

* disable email updates
@lmarini
Default to None if "owner" doesn't exists in msg (#1211)
f01c46a
@lmarini
Use healthcheck to make sure elasticsearch has (#1212)
dba247a 
started before starting backend.

Backend used to fail with docker compose prod.
@lmarini
Only show Create Feed button if in admin mode. (#1213)
70f0fb8 
This is in line with showing the feeds in the
table. Eventually we should show a disabled
button with a message saying to go into
admin mode.
@lmarini lmarini merged commit 3b61430 into main Nov 15, 2024
10 checks passed
@lmarini lmarini deleted the release/v2.0-beta-3 branch November 15, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcnichol tcnichol tcnichol approved these changes

@max-zilla max-zilla Awaiting requested review from max-zilla max-zilla is a code owner

@lmarini lmarini Awaiting requested review from lmarini lmarini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@longshuicy @lmarini @tcnichol @GalMunGral