Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

824 display more information on the extractor popup #841

Merged
merged 11 commits into from
Dec 12, 2023
Merged

824 display more information on the extractor popup #841

merged 11 commits into from
Dec 12, 2023

Conversation

longshuicy
Copy link
Member

@longshuicy longshuicy commented Nov 30, 2023 •
edited
Loading

image image image

@longshuicy longshuicy linked an issue Nov 30, 2023 that may be closed by this pull request
Display more information on the extractor popup #824
Closed
lmarini
lmarini requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Three minor suggestions:

  • Could we get a close button or x in top right for popup?
  • The tables on the files and the extraction history tabs have borders. To be consistent should we have one here as well?
  • Not changed in this PR, but when an extractor is not alive, should we still be able to click on the title and get the description? Right now we can't.
    Thanks!

@longshuicy
Copy link
Member Author

Looks great. Three minor suggestions:

  • Could we get a close button or x in top right for popup?
  • The tables on the files and the extraction history tabs have borders. To be consistent should we have one here as well?
  • Not changed in this PR, but when an extractor is not alive, should we still be able to click on the title and get the description? Right now we can't.
    Thanks!

I think i addressed all of them. i also rewrote the searchbox (using generic search component we have), as well as align them better.
image
image

tcnichol
tcnichol approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I like the expanded info on both the extractor page and on submit.

Marking approved.

@lmarini lmarini merged commit 66abc2e into main Dec 12, 2023
5 checks passed
@lmarini lmarini deleted the 824-display-more-information-on-the-extractor-popup branch December 12, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarini lmarini lmarini approved these changes

@max-zilla max-zilla max-zilla approved these changes

@tcnichol tcnichol tcnichol approved these changes

@ddey2 ddey2 Awaiting requested review from ddey2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display more information on the extractor popup
4 participants
@longshuicy @lmarini @max-zilla @tcnichol