Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow message and heartbeat image and tag to be overwrite #858

Merged

Conversation

longshuicy
Copy link
Member

No description provided.

@longshuicy longshuicy requested a review from robkooper December 19, 2023 16:10
@longshuicy longshuicy requested a review from lmarini as a code owner December 19, 2023 16:10
@longshuicy longshuicy linked an issue Dec 19, 2023 that may be closed by this pull request
@longshuicy longshuicy changed the title allow message nad heartbeat image and tag to be overwrite allow message and heartbeat image and tag to be overwrite Dec 19, 2023
Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to comment out the tag: main

@lmarini lmarini requested a review from robkooper December 20, 2023 16:32
@lmarini lmarini merged commit a5bc432 into main Dec 20, 2023
5 checks passed
@lmarini lmarini deleted the 857-make-imagetag-a-variable-in-the-k8s-deployment-template branch December 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make image/tag a variable in the k8s deployment template
3 participants