Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

892 latest main branch is not building the frontend image correct #893

Conversation

longshuicy
Copy link
Member

@longshuicy longshuicy commented Jan 22, 2024

The typo is causing the build failure.

To test:

  1. Build a test image by cd frontend and run docker build -t clowder/clowder2-frontend:test-build .
  2. point the frontend in docker-compose.yml to this image image: "clowder/clowder2-frontend:test-build"
  3. docker compose up

Some helpful command e.g. get into the built image to check nginx folder
docker run -it clowder/clowder2-frontend:test-build /bin/sh
You should see all the bundles there
image

@longshuicy longshuicy requested review from ddey2 and tcnichol January 22, 2024 16:45
@longshuicy longshuicy requested a review from lmarini as a code owner January 22, 2024 16:45
@longshuicy longshuicy linked an issue Jan 22, 2024 that may be closed by this pull request
@tcnichol
Copy link
Contributor

I built the docker image with
docker build -t clowder/clowder2-frontend:test-build .

and then used that image in the docker-compose file for frontend and it is now working.

and i am seeing all the bundles inside

/usr/share/nginx/html

Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build the image, had docker-compose point to that image, and checked for bundles. Everything is working as it should now.

@longshuicy
Copy link
Member Author

I built the docker image with docker build -t clowder/clowder2-frontend:test-build .

and then used that image in the docker-compose file for frontend and it is now working.

and i am seeing all the bundles inside

/usr/share/nginx/html

Yes I updated my description of the PR. I made some typo there. Thank you for sharing how to correctly build the image.

@longshuicy longshuicy merged commit bedb957 into main Jan 22, 2024
6 checks passed
@longshuicy longshuicy deleted the 892-latest-main-branch-is-not-building-the-frontend-image-correct branch January 22, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest main branch is not building the frontend image correct
3 participants