Drag and Drop One or More Files #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will eventually combine all file uploads
select selects files but misses the first one
removing console logs
|
Should I make this against the next release instead of main? |
ddey2
reviewed
Feb 20, 2024
|
I tested, it works. I was able to successfully drag and drop one/multiple files. I have few UI suggestions.
2. wierd thing ---> I see 'n' after the button. Once I click on the button and uploads a file, it's gone but something else appears.
|
|
@ddey2 For the n, I haven't been able to replicate it locally. Let me know if it still shows up. |
|
@tcnichol I still see the n. For testing, I opened it in a private Mozilla window, it showed a different label for the button along with a N. I think you're probably using inbuilt class. @longshuicy Could you check at your end if you see something like the attached ss? |
longshuicy
added a commit
that referenced
this pull request
Mar 22, 2024
* initial commit, add dependency, new class will eventually combine all file uploads * working on adding upload drag and drop * page does not load * drag and drop does not actually work * addign fileinputdrop as independent component * add fileupload drop inside uploadfiledraganddrop * drag and drop does not add files select selects files but misses the first one * drag and drop works now, is overwritten if file selected using button, need to fix * uploads but overwrites, need to fix * works for the select, need to fix other * should work for drop now too * was not an array * delete icon works removing console logs * drag and drop and select means other upload methods no longer needed * removing text in drag and drop * added to styles but not using because it does not work * some changes, not sure how to do rest * fix button * return to dataset * remove unnecessary imports --------- Co-authored-by: Chen Wang <[email protected]>
longshuicy
added a commit
that referenced
this pull request
Mar 22, 2024
* clear more breakpoints and move role to the Details * bump version up * add version to public layout too * update changelog * package json version * Pre commit autoformat (#846) * Removed unused imports using autoflake. * Ordered imports using isort. * Reformatted using black. * Setting up pre-commits. * Ran pre-commit an all files. * Working on creating openapi.json without running backend to be used with codegen. * Fixed `MUI: The Tabs component doesn't accept a Fragment as a child.` * Fixed runtime error due to replacing `== None` with 'is None'. * Fixed runtime error due to replacing `== None` with 'is None'. * Automatically generate openapi json file using pre-commit hook. * Added codegen precommit hook. * Setting up prettier and eslint. * First run of prettier. * Runnin eslint and prettier as hooks. * Skip codegen directories when running eslint and prettier. * Flake8 E711 exception. Required for Beanie query to work. * Fixed search_users_prefix codegen stub. * Fixed beanie query for get_dataset_folders. * Ignore Flake8 E711 since beanie query do not support `is None`. * bump keycloak chart version to 13 so it's using keycloak appversion 20 * update chart lock * add login to github repo * push set to true * revert login to github repo * version updates * revert * no v in the appVersion * change to make keycloak point to external url (#942) * 929 message on empty page if there is no datasets (#930) * basic message, need to improve * adding a login or register button * removing buttons * links to login or register if no public datasets * changing text * srink the version and align to left (#950) * moved key to grid instead of card * adding admin mode to the authwrapper (#951) * Fixed dataset parameters. They weren't being included in rabbtimq message. (#957) * fix extractor bugs and deployment script bug (#958) * Use --host 0.0.0.0 when running uvicorn to make backend listen on host IP. * fix missing add metadata button on dataset pycharm was complaining about missing publicView boolean in DisplayMetadata * Drag and Drop One or More Files (#935) * initial commit, add dependency, new class will eventually combine all file uploads * working on adding upload drag and drop * page does not load * drag and drop does not actually work * addign fileinputdrop as independent component * add fileupload drop inside uploadfiledraganddrop * drag and drop does not add files select selects files but misses the first one * drag and drop works now, is overwritten if file selected using button, need to fix * uploads but overwrites, need to fix * works for the select, need to fix other * should work for drop now too * was not an array * delete icon works removing console logs * drag and drop and select means other upload methods no longer needed * removing text in drag and drop * added to styles but not using because it does not work * some changes, not sure how to do rest * fix button * return to dataset * remove unnecessary imports --------- Co-authored-by: Chen Wang <[email protected]> * precommits --------- Co-authored-by: Luigi Marini <[email protected]> Co-authored-by: Todd Nicholson <[email protected]> Co-authored-by: toddn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new feature is added. We can now either drag and drop or select multiple files using the same upload dialog. The old ones have been removed since this handles both single and multiple files using either method.
This currently just works with files, not folders. A zip file is uploaded as a zip file. More options to come with later pull requests.