Add tests for all commands and perform some minor code cleanup/maintenance

src/Clue/PharComposer/App.php

@@ -16,9 +16,6 @@ public function __construct()
         $this->add(new Command\Build());
         $this->add(new Command\Search());
         $this->add(new Command\Install());
-
-        // GUI feature disabled for now, see #35
-        // $this->add(new Command\Gui());
     }
 
     /**
@@ -32,20 +29,11 @@ protected function getCommandName(InputInterface $input)
     {
         if ($input->getFirstArgument() === null && !$input->hasParameterOption(array('--help', '-h'))) {
             $this->isDefault = true;
-            return $this->getDefaultCommandName();
+            return 'search';
         }
         return parent::getCommandName($input);
     }
 
-    private function getDefaultCommandName()
-    {
-        $gui = $this->has('gui') ? $this->get('gui') : null;
-        if ($gui instanceof Command\Gui && $gui->hasZenity()) {
-            return 'gui';
-        }
-        return 'search';
-    }
-
     /**
      * Overridden so that the application doesn't expect the command
      * name to be the first argument.

src/Clue/PharComposer/Command/Build.php

@@ -2,41 +2,41 @@
 
 namespace Clue\PharComposer\Command;
 
-use Symfony\Component\Console\Formatter\OutputFormatterStyle;
-use Symfony\Component\Console\Helper\DialogHelper;
-use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\InputArgument;
+use Clue\PharComposer\Phar\Packager;
 use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-use Clue\PharComposer\Phar\PharComposer;
-use InvalidArgumentException;
-use UnexpectedValueException;
-use Symfony\Component\Console\Output\Output;
-use Symfony\Component\Process\Process;
-use Symfony\Component\Process\ExecutableFinder;
-use Clue\PharComposer\Phar\Packager;
 
 class Build extends Command
 {
+    /** @var Packager */
+    private $packager;
+
+    public function __construct(Packager $packager = null)
+    {
+        parent::__construct();
+
+        if ($packager === null) {
+            $packager = new Packager();
+        }
+        $this->packager = $packager;
+    }
+
     protected function configure()
     {
         $this->setName('build')
              ->setDescription('Build phar for the given composer project')
-             ->addArgument('path', InputArgument::OPTIONAL, 'Path to project directory or composer.json', '.')
+             ->addArgument('project', InputArgument::OPTIONAL, 'Path to project directory or composer.json', '.')
              ->addArgument('target', InputArgument::OPTIONAL, 'Path to write phar output to (defaults to project name)');
     }
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $packager = new Packager();
-        $packager->setOutput(function ($line) use ($output) {
-            $output->write($line);
-        });
-
-        $packager->coerceWritable();
+        $this->packager->setOutput($output);
+        $this->packager->coerceWritable();
 
-        $pharer = $packager->getPharer($input->getArgument('path'));
+        $pharer = $this->packager->getPharer($input->getArgument('project'));
 
         $target = $input->getArgument('target');
         if ($target !== null) {