Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix choice() default handling #40

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix choice() default handling #40

merged 1 commit into from
Jul 27, 2021

Conversation

fauxpark
Copy link
Contributor

Since default is an index into the array of choices, and 0 is falsy but a valid value.

@fauxpark fauxpark mentioned this pull request Jul 25, 2021
Merged
14 tasks
@Erovia Erovia requested a review from skullydazed July 26, 2021 09:33
@skullydazed skullydazed merged commit fe0bb0a into clueboard:master Jul 27, 2021
@skullydazed
Copy link
Collaborator

Thanks!

@fauxpark fauxpark deleted the fix-choice-default branch July 27, 2021 00:58
skullydazed pushed a commit that referenced this pull request Aug 10, 2021
@fauxpark @skullydazed
fix: Fix choice() default handling (#40)
c1592e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @skullydazed @Erovia