-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zstd compressor dummy #2
Conversation
Comment out zstd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly formatting issues (always use the project's .clang-format
).
One bug and an open question about adding BLOSC as a dependency.
If you can do this asap, I will make a second pass. ;-)
@@ -220,3 +222,7 @@ openexr_define_library(OpenEXR | |||
OpenEXR::IlmThread | |||
OpenEXR::OpenEXRCore | |||
) | |||
|
|||
target_include_directories(OpenEXR PUBLIC "/home/vladal/bin/include/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we fix this ? I will check how deps are generally handled here.
Co-authored-by: Philippe Leprince <[email protected]> Signed-off-by: Vlad Lazar <[email protected]>
…nto zstd-compressor
c692b48
to
720c4f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Vlad !
Co-authored-by: Philippe Leprince <[email protected]> Signed-off-by: Vlad Lazar <[email protected]>
…nto zstd-compressor
Signed-off-by: Philippe Leprince <[email protected]>
No description provided.