Fix durview 16colors crash

[tmck-code]

Context

This attempts to fix the release-blocking bug mentioned in #91

Changes

Essentially, the file_list is empty after deselecting all options. This happens somewhere in the very large method.

After some stumbling around and some feedback from cmang, I noticed that there was a commented else statement at the bottom of the loop, which seems to previously have re-populated the file_list with files and folders from the user's CWD.

https://github.com/cmang/durdraw/pull/94/files#diff-1e5995f8f73af74bc0296a94b0e316dcddab68b97c5302584a32b947dce096daR4909

• this local file searching is done a few times within the giant loop, and it's done slightly differently, I'm unsure why but there's mostly likely a reason
• in lieu of taking an axe to it, I instead extracted out one version of the file discovery into a separate method
  • The code that I extracted was at the beginning of the mouse input logic, as clicking with the mouse produced the correct (non-crash) result in the UI
  • Doing this did not, as it turns out, solve the issue
• I used the same extracted method in the else block that I discovered at the bottom of the loop and it's looking 90% similar
  • the only remaining difference that I can see is that the colours are different (see below)

Demo

Screen.Recording.2025-01-30.at.7.25.58.pm.mov

first attempt

screen-20250130-084322.2.mp4

I branched this off my crash logging PR #93, but I think the order doesn't matter/you could just merge this one if you prefer 🤙

[cmang]

Nice! Seems like a reasonable way to deal with the spaghetti. (I am open to just redoing openFilePicker() to handle navigating the directory structures in a more logical way, but haven't got my head around how quite yet.)

Still a problem: When you un-check "[X] 16colo.rs archive" with the mouse, it repopulates the interface with the list of directories and files in the local filesystem. When you un-check that with the keyboard, it doesn't, instead leaving the list blank.

[tmck-code]

I am open to just redoing openFilePicker() to handle navigating the directory structures in a more logical way

I think an easy start to this would be converting the nested if statements to early continue instead, I'll have a stab at it

Still a problem: When you un-check "[X] 16colo.rs archive" with the mouse, it repopulates the interface with the list of directories and files in the local filesystem. When you un-check that with the keyboard, it doesn't, instead leaving the list blank.

Ooh legend thanks for the feedback! I'll ensure that the keyboard produces the same behaviour as the mouse 🐁

[tmck-code]

@cmang It's so close now! The only difference that I can see is that the folders/files are different colours when clicked vs using enter/spacebar, do you know how that's done?

[cmang]

@cmang It's so close now! The only difference that I can see is that the folders/files are different colours when clicked vs using enter/spacebar, do you know how that's done?

Honestly... this is a bug I am willing to live with for now. Lol. This is feeling pretty solid.

I am not sure why yet. But it looks like maybe in one mode, folders[] is being populated (where they show as menuTitleColor), and in the other, it isn't.

[cmang]

I'm thinking of going ahead with the merge and worrying about the colors later. I still want to add more features before the release. Maybe we can tackle the colors as a separate patch. I can work on that.

Tom, as always, I appreciate your work here!

[tmck-code]

I'm thinking of going ahead with the merge and worrying about the colors later. I still want to add more features before the release. Maybe we can tackle the colors as a separate patch. I can work on that.

Tom, as always, I appreciate your work here!

You're very welcome! I'm enjoying working on this a lot. Feel free to merge if you're happy with it 🙂

[cmang]

This is good!