Fix: #1705 tbc sap #253
Fix: #1705 tbc sap #253
Conversation
|
I am afraid that this does not solve the underlying issue. The issue is not just specific for EAI. The real issue exists in SetIncapacitatedState and the renewal of movement. I will try to address the issue today and I will notify you to check that this PR is no longer needed. |
|
@killerwife Thank you for your input. I had tried to start a discussion about this issue via the issue thread but it seemed pretty dead and I did not get any response. I really want to contribute, but I initially found navigating around for the problem was an even bigger hurdle for a new contributor. This was the only solution I found. I will also look into a SetIncapacitatedState and see if I can come up with something more robust. Something like here ? Ive looked into this and into the other Unit states. tl dr; If you give me more clues to where this issue is, I am willing to work on it :) |
|
I am sorry, I didn't get to your thing, and now I got sick. I will try to push something and link it today. |
|
@SilvioDoMine confirmed that its working now. |
Fixed [TBC] Rogue's SAP snares creatures when used followed by an spell
Had to resubmit this pull to build off the latest build changes instead of my own (Ops)
After countless hours of looking where this problem could lie and testing different configurations, I finally found a simple fix that allows mobs to move after being incapacitated. It seems as though there is no UNIT_FLAG enum that defines an incapacitated state. For the future I think that should be implemented to easier break this condition.
Related issue can be found here