Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Run build on PHP 7.3 instead of PHP 7.2 #2

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix: Run build on PHP 7.3 instead of PHP 7.2 #2

merged 1 commit into from
Jul 4, 2022

Conversation

localheinz
Copy link

This pull requests

  • runs the build on PHP 7.3 instead of PHP 7.2

@cmb69 cmb69 merged commit 8a16356 into cmb69:cmb/tests Jul 4, 2022
@cmb69
Copy link
Owner

cmb69 commented Jul 4, 2022

Thank you!

@localheinz localheinz deleted the fix/php-version branch July 4, 2022 15:25
@localheinz
Copy link
Author

Thank you, @cmb69!

cmb69 pushed a commit that referenced this pull request Jul 29, 2022
@Ayesh
Micro Optimizations - Round #2
d40890d 
* .gitignore: Remove redundant entry

* Minor optimizations with ternary operators

* Use `const` instead of `define()` where appropriate

`const` is quite faster because of the compile-time optimizations. Because the replaced statements are not declaring constant conditionally, it's safe to use `const` in all of these places.

Closes phpGH-608.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @cmb69