Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

%user-aliases% should be %user_aliases% #1675

Closed
step- opened this issue Feb 28, 2018 · 6 comments
Closed

%user-aliases% should be %user_aliases% #1675

step- opened this issue Feb 28, 2018 · 6 comments
Assignees
@daxgames

Comments

@step-
Copy link

step- commented Feb 28, 2018 •
edited
Loading

I think all instances of %user-aliases% and user-aliases= in vendor\init.bat (and possibly other files) should be %user_aliases% and user_aliases respectively. The dash isn't a valid character for batch script identifiers.

Running mini version 1.3.5 Win10 x64.
@daxgames
Copy link
Member

daxgames commented Mar 3, 2018

@step Why? Is something not working?

@step-
Copy link
Author

step- commented Mar 5, 2018

Yes, I get a syntax error message, recalling from memory, something like "-aliases is an invalid identifier". Possibly my %CmdSpec% (TCC) is fussier than CMD about identifiers, I'm not sure.

@CollinChaffin
Copy link

Yes, the entire thing blows up with TCC due to the dash. I agree why not keep it consistent all the conemu vars use underscores.

Otherwise, you wind up with stuff like this in cmder (running the init.bat with TCC):

TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" echo "D:\Data\My"
TCC: Unknown command "/c" type "D:\Data\My"

@Stanzilla
Copy link
Member

fixed

daxgames added a commit that referenced this issue Aug 31, 2018
@daxgames
rename user-profile.* user_profile.* to resolve #1806, #1675
3a46aee
@daxgames daxgames mentioned this issue Aug 31, 2018
Merged
daxgames added a commit that referenced this issue Aug 31, 2018
@daxgames
rename user-profile.* user_profile.* to resolve #1806, #1675
71827e6
daxgames added a commit that referenced this issue Aug 31, 2018
@daxgames
rename user-profile.* user_profile.* to resolve #1806, #1675
0b53426
@daxgames
Copy link
Member

Fixed

Stanzilla pushed a commit that referenced this issue Aug 31, 2018
@daxgames @Stanzilla
Fix #1806 #1675 (#1870)
49da374 
## Rename user-profile.* user_profile.* to resolve #1806, #1675

* This is a backward compatible fix and will automatically and silently rename users '%cmder_root%/config/user-profile.\*' to '%cmder_root%/config/user_profile.\*' and '[user_specified_config_root]/user-profile.\*' to '[user_specified_config_root]/user_profile.\*' if the sources exist.

  * Cmder.exe does this for cmd.exe sessions.
  * The init scripts for bash and Powershell handles it for these shells
@daxgames daxgames mentioned this issue Sep 1, 2018
Merged
@daxgames
Copy link
Member

daxgames commented Sep 2, 2018

not fixed - probably can't fix TCC/LE that I have access to appears to be incompatible with cmd.exe despite their docs saying it is.

@bllngr bllngr mentioned this issue Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daxgames daxgames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Stanzilla @step- @daxgames @CollinChaffin