Fix icons #731
Merged
Fix icons #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 24, 2015 14:45
… 100% supported Cmder tasks
… an ico if launched from the cmder.bat file
|
Was the current way of trying to get the icon from the exe not working? |
|
It would probably work fine if I could build the cmder.exe but I can't because I do not have the tools. I, and anyone else trying/developing on the dev branch that cannot build the exe, use the cmder.bat to start cmder hence no icons. I just did what I did so it would work all the time with or without the cmder.exe. To me working all the time was better than working some of the time even if the cmder.bat is deprecated. |
|
Makes sense |
|
Any possibility of moving that last commit to a separate pull request? It has nothing to do with fixing the icons 😄 |
|
Sure. Will do later today. |
|
Done |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Git for Windows icon to mintty tasks to differentiate them from 100% supported Cmder tasks
Get 100% supported Cmder task icons from icons\Cmder.ico so tabs have an ico if launched from the cmder.bat file