Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReportWebVitalsConfig param is not optional in commands.d.ts for reportVitals command #31

Closed
angry-beaver opened this issue Dec 12, 2023 · 1 comment · Fixed by #32
Closed

ReportWebVitalsConfig param is not optional in commands.d.ts for reportVitals command #31

angry-beaver opened this issue Dec 12, 2023 · 1 comment · Fixed by #32
Labels
bug Something isn't working

Comments

@angry-beaver
Copy link

angry-beaver commented Dec 12, 2023 •
edited
Loading

Issue

ReportWebVitalsConfig param is not optional in commands.d.ts for reportVitals command.

Setup:

  • cypress-web-vitals version: 4.1.0

Details

Screenshot 2023-12-12 at 14 08 32
@angry-beaver angry-beaver changed the title ReportWebVitalsConfig param is not optional in command.d.ts for reportVitals command ReportWebVitalsConfig param is not optional in commands.d.ts for reportVitals command Dec 12, 2023
@cmorten cmorten added the bug Something isn't working label Dec 12, 2023
@cmorten
Copy link
Owner

cmorten commented Dec 12, 2023

You’re right, this should be optional.

cypress-web-vitals/commands.d.ts

Line 162 in 4eaa29c

reportVitals(reportWebVitalsConfig: ReportWebVitalsConfig);
needs updating

@jlp-craigmorten jlp-craigmorten mentioned this issue Dec 14, 2023
Merged
2 tasks
cmorten pushed a commit that referenced this issue Dec 14, 2023
@jlp-craigmorten
[#31] type updates to allow optional config (#32)
07afc6f 
* fix: type updates to allow optional config

* chore: disable chrome web security while testing on 3rd party sites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#31] type updates to allow optional config
2 participants
@angry-beaver @cmorten