Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#19] Missing LCP #20

Merged
merged 5 commits into from
Jan 27, 2023
Merged

[#19] Missing LCP #20

merged 5 commits into from
Jan 27, 2023

Conversation

cmorten
Copy link
Owner

@cmorten cmorten commented Jan 27, 2023 •
edited
Loading

Issue

Fixes #19

Details

  • feat: upgrade web-vitals
  • feat: update to Node 18
  • chore: update development dependencies
  • chore: update CI actions
  • test: run CI against 12.x
  • fix: don't interact with the page until load event otherwise LCP metrics don't get reported

CheckList

  • PR starts with [#ISSUE_ID].
  • Has been tested (where required).

@cmorten cmorten marked this pull request as ready for review January 27, 2023 13:50
@cmorten cmorten added bug Something isn't working dependencies labels Jan 27, 2023
@cmorten cmorten merged commit 9edeba2 into main Jan 27, 2023
@cmorten cmorten deleted the feat/issue-19-missing-lcp branch May 25, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LCP is not being calculated
1 participant
@cmorten