Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-Platform Path Separatores in serveStatic #145

Closed
cawoodm opened this issue Oct 14, 2021 · 1 comment · Fixed by #153
Closed

Cross-Platform Path Separatores in serveStatic #145

cawoodm opened this issue Oct 14, 2021 · 1 comment · Fixed by #153
Labels
bug Something isn't working needs investigation Work needs to be done before this can be actioned

Comments

@cawoodm
Copy link

cawoodm commented Oct 14, 2021

Issue

Setup:

  • deno 1.14.3 (release, x86_64-pc-windows-msvc)
  • v8 9.4.146.19
  • typescript 4.4.2
  • Opine Version: 1.8.0

Details

The path separator \ for windows is inconsistently applied in serveStatic.ts and send.ts. In particular hasTrailingSlash() assumes / whereas the path which has been normalize() contains (and may end with) \.

image
@asos-craigmorten asos-craigmorten added bug Something isn't working needs investigation Work needs to be done before this can be actioned labels Oct 25, 2021
@cmorten cmorten mentioned this issue Jan 1, 2022
Merged
2 tasks
cmorten added a commit that referenced this issue Jan 1, 2022
@cmorten
[#145] [#151] don't close file before fully read to stream (#153)
75985ee
@cmorten
Copy link
Owner

cmorten commented Jan 1, 2022

Hey @cawoodm 👋

I think I've released a fix for this, but could have missed somewhere! Would you be able to check if you still have the same issues with [email protected]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs investigation Work needs to be done before this can be actioned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#145] [#151] don't close file before fully read to stream cmorten/opine
3 participants
@cawoodm @cmorten @asos-craigmorten