Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on deno std, or opine ??? #147

Closed
waghanza opened this issue Nov 13, 2021 · 4 comments · Fixed by #148
Closed

Bug on deno std, or opine ??? #147

waghanza opened this issue Nov 13, 2021 · 4 comments · Fixed by #148
Assignees
Labels
bug Something isn't working dependencies

Comments

@waghanza
Copy link

Hi @asos-craigmorten,

Trying to add opine to https://github.com/the-benchmarker/web-frameworks. I am facing the following error

error: TS2339 [ERROR]: Property 'getIterator' does not exist on type 'ReadableStream<R>'.
  return res.readable.getIterator();
                      ~~~~~~~~~~~
    at https://deno.land/std@0.69.0/async/pool.ts:45:23

Setup:

  • Deno Version: 1.16.1 (alpine)
  • v8 Version: 9.7.106.2
  • Typescript Version: 4.4.2
  • Opine Version: 1.9.0

Source code:

import { opine } from "https://deno.land/x/[email protected]/mod.ts";

const app = opine();

app.get("/", function (_, res) {
  res.send("");
});

app.get("/user/:id", (req, res) => {
    res.end(req.params.id);
})

app.post("/user", (_, res) => {
    res.end("");
})

app.listen("0.0.0.0:3000");

Regards,

@yacinehmito
Copy link

I've just been hit by the same issue.

@cmorten
Copy link
Owner

cmorten commented Nov 14, 2021

@waghanza @yacinehmito

Hey folks 👋

Thanks for flagging this - hopefully https://deno.land/x/[email protected] resolves the issue. Please reopen if otherwise!

I suspect Opine will benchmark fairly low on that list 😅 contrary to efforts on the Deno std lib, with Opine the focus was always feature support over performance... perhaps should try to remedy that 🤔 awesome to hear that you're trying to get Deno projects onto that list though! 🚀

@saipasha
Copy link

Thank you for the fast action. I just ran into the same issue.

@yacinehmito
Copy link

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies
Projects
None yet
4 participants