-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ONNX file for FastSim refinement backport for Run 2 DeepJet tagging #15
Conversation
A new Pull Request was created by @sbein (Sam Bein) for branch CMSSW_10_6_X. @smuzaffar, @swertz, @vlimant, @aandvalenzuela, @iarspider, @cmsbuild, @simonepigazzini can you please review it and eventually sign? Thanks. |
+externals |
Pull request #15 was updated. |
Hi @smuzaffar, I just refreshed the model with Moritz's latest onnx file. Can we merge this soon? Thnxs. |
@sbein , I think it is better to rerunthe tests for cms-sw/cmssw#40828 with this updated data |
we need to merge this I think +1 |
@aandvalenzuela I think we should have run the usual tests before merging: this was updated on May 12, and never tested since then! |
Sorry @perrotta! I though it was already tested by cms-sw/cmssw#40828 (that was already merged three weeks ago). |
Ah, ok. Yes, it was tested with #40828, and just forgot while merging that one. |
Hi @smuzaffar @perrotta @rappoccio @sbein @antoniovilela I confuse a bit on this PR and CMSSW_10_6_35. Currently, the production stuck because of missing model, btagDeepFlavRefineNN_CHS.onnx, issue. See here). However, I see it in Do we somehow miss something? Thx. |
Ah, I think I know. We need CMSSW_10_6_36, which include Update tag for PhysicsTools-NanoAOD to V01-01-00-01-00 [10_6_X] |
The added file complements the CMSSW backport cms-sw/cmssw#40828, which implements the FastSim refinement of the DeepJet collections.