Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model checksums #5

Merged
merged 1 commit into from
Jan 24, 2024
Merged

add model checksums #5

merged 1 commit into from
Jan 24, 2024

Conversation

kpedro88
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch main.

@smuzaffar, @aandvalenzuela, @jfernan2, @iarspider, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2024

cms-bot internal usage

@kpedro88 kpedro88 mentioned this pull request Jan 10, 2024
17 tasks
@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25b676/36866/summary.html
COMMIT: 797b72e
CMSSW: CMSSW_14_0_X_2024-01-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoEcal-EgammaClusterProducers/5/36866/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25b676/36866/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25b676/36866/git-merge-result

Comparison Summary

Summary:

@kpedro88
Copy link
Contributor Author

@cms-sw/reconstruction-l2 please sign so we can move to the next step of the plan in cms-sw/cmssw#43695

@smuzaffar
Copy link
Contributor

@kpedro88 , why not run tests with cms-sw/cmssw#43696 to make sure cmsTritonConfigTool properly process the config.pbtxt change here?

@kpedro88
Copy link
Contributor Author

@smuzaffar I've run such tests privately. I was hoping to avoid having to list the N-1 related PRs in every PR in this group to run such tests centrally. The changes in the cms-data PRs are harmless taken alone, so it should be fine to just integrate them first.

@smuzaffar
Copy link
Contributor

+externals

@mandrenguyen
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

+1

@cmsbuild cmsbuild merged commit c7e1bf9 into cms-data:main Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants